Skip to content

fix(cache): report prune removal failures accurately - #1285

Merged
yvgude merged 1 commit into
yvgude:mainfrom
cedric013:fix/1281-prune-cache-metrics
Jul 27, 2026
Merged

fix(cache): report prune removal failures accurately#1285
yvgude merged 1 commit into
yvgude:mainfrom
cedric013:fix/1281-prune-cache-metrics

Conversation

@cedric013

@cedric013 cedric013 commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Track failed BM25/graph cache prune removals explicitly.
  • Count removed entries and freed bytes only after filesystem deletion succeeds.
  • Surface failed removals in cache prune and doctor output.
  • Add regression coverage for failed BM25 directory removal.

Closes #1281

Tests

  • rustfmt --edition 2024 --check src/cli/config_cmd.rs src/doctor/fix.rs tests/index_scoping_scenarios.rs
  • cargo test -q --test index_scoping_scenarios prune_bm25_counts_failed_remove_without_freed_bytes (cancelled after hanging in this workspace; CI will run the full suite)

@cedric013
cedric013 force-pushed the fix/1281-prune-cache-metrics branch from 4f887ce to 0d13b0b Compare July 27, 2026 12:57
@yvgude
yvgude merged commit 9272bdd into yvgude:main Jul 27, 2026
25 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix cache prune metrics on failed removals

2 participants

@cedric013 @yvgude